Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(glog_component): prefix package and namespace with autoware #9302

Merged
merged 3 commits into from
Dec 4, 2024
Merged

refactor(glog_component): prefix package and namespace with autoware #9302

merged 3 commits into from
Dec 4, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 12, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 12, 2024
This was referenced Nov 12, 2024
Open
Open
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.46%. Comparing base (ed133eb) to head (1200ad5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mon/autoware_glog_component/src/glog_component.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9302      +/-   ##
==========================================
- Coverage   29.51%   29.46%   -0.05%     
==========================================
  Files        1446     1455       +9     
  Lines      108518   108593      +75     
  Branches    41396    41400       +4     
==========================================
- Hits        32025    31999      -26     
- Misses      73372    73476     +104     
+ Partials     3121     3118       -3
Flag Coverage Δ *Carryforward flag
differential 9.78% <0.00%> (?)
total 29.48% <ø> (-0.03%) ⬇️ Carriedforward from ed133eb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve force-pushed the prefix-glog_component branch from b159bfb to 1c89a3e Compare November 12, 2024 12:15
@esteve esteve marked this pull request as ready for review November 12, 2024 12:15
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 12, 2024
@esteve esteve changed the title refactor(glog_component): prefix package and namespace with autoware chore(glog_component): prefix package and namespace with autoware Nov 20, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Nov 20, 2024 •
edited
Loading

Sorry I pasted it from the other place, the table refers to glog_component. Edited the comment.

I've renamed the title to refactor because it is renaming the package name in source files and file names themselves.

Since there are code changes, we cannot use chore to refer to these prefixing PRs.

References:

@xmfcx xmfcx mentioned this pull request Nov 20, 2024
Merged
@esteve
Copy link
Contributor Author

esteve commented Nov 20, 2024

I agree with refactor, I've used it in the past, but our pr-label check was failing.

@xmfcx xmfcx changed the title chore(glog_component): prefix package and namespace with autoware refactor(glog_component): prefix package and namespace with autoware Nov 20, 2024
@esteve esteve force-pushed the prefix-glog_component branch from fc2e701 to ec44652 Compare November 20, 2024 12:16
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 20, 2024
This was referenced Nov 20, 2024
Merged
Merged
Merged
Merged
Merged
@esteve
Copy link
Contributor Author

esteve commented Nov 20, 2024 •
edited by xmfcx
Loading

@xmfcx I've submitted the following PRs to address your feedback:

isamu-takagi
isamu-takagi reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested this file, the class could not be found, so I think the following changes are necessary. The same goes for the launch file.

<?xml version="1.0"?>
<launch>
  <node_container pkg="rclcpp_components" exec="component_container" name="glog_container" namespace="">
    <composable_node pkg="autoware_glog_component" plugin="GlogComponent" name="glog_component"/>
  </node_container>
</launch>

common/autoware_glog_component/README.md Outdated Show resolved Hide resolved
common/autoware_glog_component/CMakeLists.txt Outdated Show resolved Hide resolved
@esteve
Copy link
Contributor Author

esteve commented Nov 25, 2024

@isamu-takagi thanks, I've applied your suggestions.

@xmfcx xmfcx self-requested a review December 4, 2024 10:01
@xmfcx xmfcx force-pushed the prefix-glog_component branch from e171ef0 to 1200ad5 Compare December 4, 2024 11:54
@esteve esteve disabled auto-merge December 4, 2024 12:28
@xmfcx
Copy link
Contributor

xmfcx commented Dec 4, 2024

image

I was able to drive autonomously with AWSIM-Labs with the latest autoware nightly repos, with all the sub-PRs rebased and checked out to main. ✅

Thanks for your efforts!

@xmfcx
Copy link
Contributor

xmfcx commented Dec 4, 2024

Also manually checked the usage of glog_component throughout the repository and checking them visually, they all seemed to have been prefixed correctly ✅

@xmfcx xmfcx merged commit 6ab469d into autowarefoundation:main Dec 4, 2024
32 of 33 checks passed
@esteve esteve deleted the prefix-glog_component branch December 4, 2024 13:41
@satoshi-ota satoshi-ota mentioned this pull request Dec 4, 2024
Merged
@SakodaShintaro SakodaShintaro mentioned this pull request Dec 6, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isamu-takagi isamu-takagi isamu-takagi left review comments

@xmfcx xmfcx xmfcx approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r is a code owner

Assignees

@esteve esteve

Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esteve @xmfcx @isamu-takagi